chore: add `region` argument to `target_table` in `aws_glue_catalog_table` #34817

bschaatsbergen · 2023-12-08T16:25:32Z

Description

Adds the region to the target_table block for both the resource and data source: aws_glue_catalog_table

Relations

References

Output from Acceptance Testing

Resource aws_glue_catalog_table :

make testacc TESTS=TestAccGlueCatalogTable_ PKG=glue                                                                                                             rbenv:3.1.0
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueCatalogTable_'  -timeout 360m
=== RUN   TestAccGlueCatalogTable_basic
=== PAUSE TestAccGlueCatalogTable_basic
=== RUN   TestAccGlueCatalogTable_columnParameters
=== PAUSE TestAccGlueCatalogTable_columnParameters
=== RUN   TestAccGlueCatalogTable_full
=== PAUSE TestAccGlueCatalogTable_full
=== RUN   TestAccGlueCatalogTable_Update_addValues
=== PAUSE TestAccGlueCatalogTable_Update_addValues
=== RUN   TestAccGlueCatalogTable_Update_replaceValues
=== PAUSE TestAccGlueCatalogTable_Update_replaceValues
=== RUN   TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== RUN   TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
=== RUN   TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== RUN   TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== RUN   TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== RUN   TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== RUN   TestAccGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccGlueCatalogTable_Disappears_database
=== PAUSE TestAccGlueCatalogTable_Disappears_database
=== RUN   TestAccGlueCatalogTable_targetTable
=== PAUSE TestAccGlueCatalogTable_targetTable
=== RUN   TestAccGlueCatalogTable_disappears
=== PAUSE TestAccGlueCatalogTable_disappears
=== RUN   TestAccGlueCatalogTable_openTableFormat
=== PAUSE TestAccGlueCatalogTable_openTableFormat
=== CONT  TestAccGlueCatalogTable_basic
=== CONT  TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== CONT  TestAccGlueCatalogTable_openTableFormat
=== CONT  TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== CONT  TestAccGlueCatalogTable_disappears
=== CONT  TestAccGlueCatalogTable_targetTable
=== CONT  TestAccGlueCatalogTable_Disappears_database
=== CONT  TestAccGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== CONT  TestAccGlueCatalogTable_Update_addValues
=== CONT  TestAccGlueCatalogTable_Update_replaceValues
=== CONT  TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== CONT  TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== CONT  TestAccGlueCatalogTable_full
=== CONT  TestAccGlueCatalogTable_columnParameters
=== CONT  TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_emptyBlock (45.47s)
=== NAME  TestAccGlueCatalogTable_Disappears_database
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting Glue Catalog Database (396541922245:tf-acc-test-5285385946469498629): EntityNotFoundException: Database tf-acc-test-5285385946469498629 not found.
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "ba4a7048-fb26-4b0d-be6f-06f85385f394"
          },
          Message_: "Database tf-acc-test-5285385946469498629 not found."
        }

--- FAIL: TestAccGlueCatalogTable_Disappears_database (48.95s)
--- PASS: TestAccGlueCatalogTable_disappears (49.32s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock (50.34s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock (50.44s)
--- PASS: TestAccGlueCatalogTable_partitionIndexesMultiple (51.65s)
--- PASS: TestAccGlueCatalogTable_columnParameters (52.97s)
--- PASS: TestAccGlueCatalogTable_partitionIndexesSingle (53.55s)
--- PASS: TestAccGlueCatalogTable_full (53.61s)
--- PASS: TestAccGlueCatalogTable_basic (55.06s)
--- PASS: TestAccGlueCatalogTable_targetTable (55.43s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN (56.21s)
--- PASS: TestAccGlueCatalogTable_Update_replaceValues (70.80s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues (70.82s)
--- PASS: TestAccGlueCatalogTable_Update_addValues (70.82s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReference (73.26s)
--- PASS: TestAccGlueCatalogTable_openTableFormat (77.54s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/glue	79.884s
FAIL
make: *** [testacc] Error 1

Data source aws_glue_catalog_table :

make testacc TESTS=TestAccGlueCatalogTableDataSource_ PKG=glue                                                                                                    rbenv:3.1.0
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueCatalogTableDataSource_'  -timeout 360m
=== RUN   TestAccGlueCatalogTableDataSource_basic
=== PAUSE TestAccGlueCatalogTableDataSource_basic
=== CONT  TestAccGlueCatalogTableDataSource_basic
--- PASS: TestAccGlueCatalogTableDataSource_basic (20.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	22.724s

github-actions · 2023-12-08T16:25:47Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

DrFaust92

LGTM

himavanthkj · 2023-12-27T06:44:55Z

Can this be merged.

bschaatsbergen · 2024-01-01T19:55:44Z

Hey @himavanthkj, end of year is a bit hectic for all of us, I've raised awareness around this pull request to the core team members.

dimaman2001 · 2024-01-06T15:47:13Z

Why not manage the region via the provider?

jar-b

LGTM 🎉

% make testacc TESTS="TestAccGlueCatalogTable_|TestAccGlueCatalogTableDataSource_" PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueCatalogTable_|TestAccGlueCatalogTableDataSource_'  -timeout 360m
=== RUN   TestAccGlueCatalogTableDataSource_basic
=== PAUSE TestAccGlueCatalogTableDataSource_basic
=== RUN   TestAccGlueCatalogTable_basic
=== PAUSE TestAccGlueCatalogTable_basic
=== RUN   TestAccGlueCatalogTable_columnParameters
=== PAUSE TestAccGlueCatalogTable_columnParameters
=== RUN   TestAccGlueCatalogTable_full
=== PAUSE TestAccGlueCatalogTable_full
=== RUN   TestAccGlueCatalogTable_Update_addValues
=== PAUSE TestAccGlueCatalogTable_Update_addValues
=== RUN   TestAccGlueCatalogTable_Update_replaceValues
=== PAUSE TestAccGlueCatalogTable_Update_replaceValues
=== RUN   TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== RUN   TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
=== RUN   TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== RUN   TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== RUN   TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== RUN   TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== RUN   TestAccGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccGlueCatalogTable_Disappears_database
=== PAUSE TestAccGlueCatalogTable_Disappears_database
=== RUN   TestAccGlueCatalogTable_targetTable
=== PAUSE TestAccGlueCatalogTable_targetTable
=== RUN   TestAccGlueCatalogTable_disappears
=== PAUSE TestAccGlueCatalogTable_disappears
=== RUN   TestAccGlueCatalogTable_openTableFormat
=== PAUSE TestAccGlueCatalogTable_openTableFormat
=== CONT  TestAccGlueCatalogTableDataSource_basic
=== CONT  TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== CONT  TestAccGlueCatalogTable_Disappears_database
=== CONT  TestAccGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccGlueCatalogTable_full
=== CONT  TestAccGlueCatalogTable_Update_replaceValues
=== CONT  TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
=== CONT  TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== CONT  TestAccGlueCatalogTable_columnParameters
=== CONT  TestAccGlueCatalogTable_disappears
=== CONT  TestAccGlueCatalogTable_basic
=== CONT  TestAccGlueCatalogTable_Update_addValues
=== CONT  TestAccGlueCatalogTable_openTableFormat
=== CONT  TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== CONT  TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== CONT  TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== CONT  TestAccGlueCatalogTable_targetTable
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_emptyBlock (39.86s)
--- PASS: TestAccGlueCatalogTableDataSource_basic (40.63s)
=== NAME  TestAccGlueCatalogTable_Disappears_database
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting Glue Catalog Database (727561393803:tf-acc-test-7484896852048980264): EntityNotFoundException: Database tf-acc-test-7484896852048980264 not found.
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "63121820-eca8-4661-b73c-4fb0dd260233"
          },
          Message_: "Database tf-acc-test-7484896852048980264 not found."
        }

--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock (43.69s)
--- FAIL: TestAccGlueCatalogTable_Disappears_database (43.75s)
--- PASS: TestAccGlueCatalogTable_disappears (44.01s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock (47.62s)
--- PASS: TestAccGlueCatalogTable_full (50.84s)
--- PASS: TestAccGlueCatalogTable_partitionIndexesSingle (50.84s)
--- PASS: TestAccGlueCatalogTable_columnParameters (51.33s)
--- PASS: TestAccGlueCatalogTable_basic (53.40s)
--- PASS: TestAccGlueCatalogTable_partitionIndexesMultiple (54.77s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN (55.49s)
--- PASS: TestAccGlueCatalogTable_targetTable (55.83s)
--- PASS: TestAccGlueCatalogTable_Update_addValues (70.88s)
--- PASS: TestAccGlueCatalogTable_Update_replaceValues (71.38s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues (74.36s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReference (75.95s)
--- PASS: TestAccGlueCatalogTable_openTableFormat (76.71s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/glue       80.162s

Failure is unrelated to this change.

github-actions · 2024-01-12T12:47:36Z

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-02-12T02:05:41Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

bschaatsbergen added 2 commits December 8, 2023 17:23

chore: update docs to add region to the target table

1ab2de7

chore: add region to target_table

cc71237

github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. labels Dec 8, 2023

terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Dec 8, 2023

bschaatsbergen added 9 commits December 8, 2023 17:27

chore: add region argument to target_table in data source

77162d6

chore: update data source docs to add region to the target table

23ecfbd

Create 34817.txt

d2fcaf8

chore: rm extra slash

9dcbc75

chore: fix missing curly brace

b5aaf42

chore: add region on target_table test check resource attribute pair

51790fe

chore: add region to target_table

43bddcb

chore: remove resource attribute test

5df861d

chore: use spaces

0d1f768

github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 8, 2023

DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 11, 2023

DrFaust92 approved these changes Dec 11, 2023

View reviewed changes

jar-b approved these changes Jan 8, 2024

View reviewed changes

jar-b merged commit 907c1a8 into hashicorp:main Jan 8, 2024
80 checks passed

github-actions bot added this to the v5.32.0 milestone Jan 8, 2024

github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add `region` argument to `target_table` in `aws_glue_catalog_table` #34817

chore: add `region` argument to `target_table` in `aws_glue_catalog_table` #34817

bschaatsbergen commented Dec 8, 2023 •

edited

Loading

github-actions bot commented Dec 8, 2023

DrFaust92 left a comment

himavanthkj commented Dec 27, 2023

bschaatsbergen commented Jan 1, 2024 •

edited

Loading

dimaman2001 commented Jan 6, 2024

jar-b left a comment

github-actions bot commented Jan 12, 2024

github-actions bot commented Feb 12, 2024

chore: add region argument to target_table in aws_glue_catalog_table #34817

chore: add region argument to target_table in aws_glue_catalog_table #34817

Conversation

bschaatsbergen commented Dec 8, 2023 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Dec 8, 2023

Community Note

DrFaust92 left a comment

Choose a reason for hiding this comment

himavanthkj commented Dec 27, 2023

bschaatsbergen commented Jan 1, 2024 • edited Loading

dimaman2001 commented Jan 6, 2024

jar-b left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 12, 2024

github-actions bot commented Feb 12, 2024

chore: add `region` argument to `target_table` in `aws_glue_catalog_table` #34817

chore: add `region` argument to `target_table` in `aws_glue_catalog_table` #34817

bschaatsbergen commented Dec 8, 2023 •

edited

Loading

bschaatsbergen commented Jan 1, 2024 •

edited

Loading